[01:00:34] *** Quits: ziyeyang (~ziyeyang@192.55.46.46) (Quit: Leaving) [02:15:27] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 256 seconds) [02:19:08] *** Joins: travis-ci (~travis-ci@ec2-184-72-210-94.compute-1.amazonaws.com) [02:19:09] (spdk/master) nvme_spec: Add two macros to check status of command completion (Shuhei Matsumoto) [02:19:09] Diff URL: https://github.com/spdk/spdk/compare/55be9a57a619...f76ca9a0e7a8 [02:19:09] *** Parts: travis-ci (~travis-ci@ec2-184-72-210-94.compute-1.amazonaws.com) () [02:50:44] Project irc-test build #50: SUCCESS in 47 ms: test/job/irc-test/50/ [07:12:48] *** Joins: michalwy (~michalwy@192.55.54.44) [07:14:19] Reminder: SPDK bug scrub in less than an hour. https://spdk.io/community/ [07:15:20] scrub-a-dub-dub [08:38:09] darsto, I've been going nuts this week with an ASAN error on crypto that I couldn't for the life of me figure out how my changes were even remotely related. Turns out they're not :) The issue exists on master but we're not running crypto UT on Jenkins - doing so has been pending the patches around selecting functional vs unit tests... [08:38:48] I'll enter a github issue for what's on master and am in the middle of fixing it now. FYI you introduced it with the change you made for sessions to use rte_ because of DPDK 19.02 [08:39:55] I haven't looked to see if we can enable crypto UT in the unit_tests job or not, I can do that later klateck unless you want to. Or sethhowe :) [08:48:12] *** Joins: travis-ci (~travis-ci@ec2-54-92-235-51.compute-1.amazonaws.com) [08:48:13] (spdk/master) bdev/passthru: Use typedef in bdev_module.h for spdk_bdev_unregsister (Shuhei Matsumoto) [08:48:13] Diff URL: https://github.com/spdk/spdk/compare/f76ca9a0e7a8...5cefef80395c [08:48:13] *** Parts: travis-ci (~travis-ci@ec2-54-92-235-51.compute-1.amazonaws.com) () [08:50:27] *** Joins: travis-ci (~travis-ci@ec2-54-161-198-127.compute-1.amazonaws.com) [08:50:28] (spdk/master) OCF: add support of dump_info_json (Vitaliy Mysak) [08:50:28] Diff URL: https://github.com/spdk/spdk/compare/5cefef80395c...cab1ea1c056e [08:50:28] *** Parts: travis-ci (~travis-ci@ec2-54-161-198-127.compute-1.amazonaws.com) () [09:51:06] *** Joins: jimharris (~jimharris@134.134.139.72) [09:51:06] *** ChanServ sets mode: +o jimharris [09:59:56] *** Quits: jimharris (~jimharris@134.134.139.72) (Quit: Leaving...) [10:02:33] *** Joins: jimharris (~jimharris@192.55.54.42) [10:02:34] *** ChanServ sets mode: +o jimharris [10:14:17] jenkins status pages are not updating [10:14:24] peluse: can you take a look? [10:39:43] Ok, I'm looking at this [10:46:26] Reason was polish character ł in text -> Michał Mielewczyk [10:51:07] *** Quits: nate12112_spdk (6881c05b@gateway/web/freenode/ip.104.129.192.91) (Ping timeout: 256 seconds) [10:58:44] we could use some penetration testing [11:02:58] *** Joins: travis-ci (~travis-ci@ec2-54-227-100-44.compute-1.amazonaws.com) [11:02:59] (spdk/master) bdevperf: Add the prefix "g_" to coremap (Shuhei Matsumoto) [11:02:59] Diff URL: https://github.com/spdk/spdk/compare/cab1ea1c056e...14c18abb7ad3 [11:02:59] *** Parts: travis-ci (~travis-ci@ec2-54-227-100-44.compute-1.amazonaws.com) () [11:42:18] *** Joins: travis-ci (~travis-ci@ec2-54-196-110-94.compute-1.amazonaws.com) [11:42:19] (spdk/master) scripts:Fix Python errors in checking scripts (James Bergsten) [11:42:19] Diff URL: https://github.com/spdk/spdk/compare/14c18abb7ad3...0c93fc733032 [11:42:19] *** Parts: travis-ci (~travis-ci@ec2-54-196-110-94.compute-1.amazonaws.com) () [11:43:26] sethhowe: do we have a test for https://review.gerrithub.io/c/spdk/spdk/+/443811? [11:49:23] *** Joins: travis-ci (~travis-ci@ec2-54-159-155-93.compute-1.amazonaws.com) [11:49:24] (spdk/master) rdma: properly account num_outstanding_data_wr (Seth Howell) [11:49:24] Diff URL: https://github.com/spdk/spdk/compare/1b8cbebf1c7c...92f5548a91c8 [11:49:24] *** Parts: travis-ci (~travis-ci@ec2-54-159-155-93.compute-1.amazonaws.com) () [11:53:07] *** Joins: travis-ci (~travis-ci@ec2-54-80-229-92.compute-1.amazonaws.com) [11:53:08] (spdk/master) rdma: adjust I/O unit based on device SGL support (Seth Howell) [11:53:08] Diff URL: https://github.com/spdk/spdk/compare/e7beb0d1fd4e...b6b0a0ba59a2 [11:53:08] *** Parts: travis-ci (~travis-ci@ec2-54-80-229-92.compute-1.amazonaws.com) () [12:04:36] *** Quits: drv (daniel@oak.drv.nu) (Remote host closed the connection) [12:05:13] *** Joins: drv (daniel@oak.drv.nu) [12:05:13] *** ChanServ sets mode: +o drv [12:40:51] *** Joins: thanosm (68dcf384@gateway/web/freenode/ip.104.220.243.132) [12:41:02] bwalker: https://review.gerrithub.io/c/spdk/spdk/+/443468 [12:41:10] can you take a look at my question? [12:44:52] jimharris: Not yet. The asserts should hit in the shutdown test, but let me think about other ways to stress it. [12:47:24] sure right after I eat lunch [12:47:33] I have to write it out to confirm that the indices line up [12:47:37] *** Joins: travis-ci (~travis-ci@ec2-54-227-100-44.compute-1.amazonaws.com) [12:47:38] (spdk/master) nvme: remaning changes related to nvme hooks (Darek Stojaczyk) [12:47:38] Diff URL: https://github.com/spdk/spdk/compare/b6b0a0ba59a2...655d54f3f176 [12:47:38] *** Parts: travis-ci (~travis-ci@ec2-54-227-100-44.compute-1.amazonaws.com) () [12:47:56] can you take a look at my comment on this one? https://review.gerrithub.io/c/spdk/spdk/+/444110 [12:48:14] in that simple null bdev test, pgo+lto is like a 35% improvement [12:48:21] for gcc [12:48:35] we should probably be doing all of this when running our actual performance tests [12:50:26] *** Joins: travis-ci (~travis-ci@ec2-54-227-100-44.compute-1.amazonaws.com) [12:50:27] (spdk/master) ftl: extended nightly tests (Wojciech Malikowski) [12:50:27] Diff URL: https://github.com/spdk/spdk/compare/655d54f3f176...0699216fac06 [12:50:27] *** Parts: travis-ci (~travis-ci@ec2-54-227-100-44.compute-1.amazonaws.com) () [12:52:14] jimharris: can we merge dpdk 19.02 patches? https://review.gerrithub.io/q/project:spdk%252Fdpdk+branch:spdk-19.02+status:open [12:53:13] yep - go for it [12:53:36] bwalker: looks good - +2 [12:54:04] i'm guessing we'll be reverting 2 crypto patches from there in the future, but it's probably better than having all of those patches hanging like now [13:01:15] *** Quits: jimharris (~jimharris@192.55.54.42) (Remote host closed the connection) [13:01:46] darsto: what version of gcc are you using [13:02:07] ubuntu 18 default, sec [13:03:03] gcc 7.3.0 [13:03:05] consider using a distro that stays more up to date! [13:03:15] I think the pgo stuff was greatly improved in gcc 8 [13:04:38] yeah, better pgo is one of the primary features in gcc 8 [13:04:48] I'm using that and pgo makes a pretty big difference for me [13:06:15] I just realized my clang is super old though [13:06:36] clang-6 instead of the new clang-7 [13:06:40] so I may need to try that [13:08:02] guess it hasn't been packaged on fedora just yet [13:08:15] there's a million clang sanitizers these days too that we should be considering using [13:11:38] *** Joins: jimharris (~jimharris@134.134.139.72) [13:11:38] *** ChanServ sets mode: +o jimharris [13:29:39] *** Quits: jimharris (~jimharris@134.134.139.72) (Remote host closed the connection) [13:46:21] *** Joins: travis-ci (~travis-ci@ec2-54-227-100-44.compute-1.amazonaws.com) [13:46:22] (spdk/master) nvmf_tgt: read ret from spdk_nvmf_poll_group_add. (Seth Howell) [13:46:22] Diff URL: https://github.com/spdk/spdk/compare/0699216fac06...c1e0bded59d7 [13:46:22] *** Parts: travis-ci (~travis-ci@ec2-54-227-100-44.compute-1.amazonaws.com) () [14:06:10] *** Quits: drv (daniel@oak.drv.nu) (Remote host closed the connection) [14:06:53] *** Joins: drv (daniel@oak.drv.nu) [14:06:53] *** ChanServ sets mode: +o drv [14:21:21] *** Quits: thanosm (68dcf384@gateway/web/freenode/ip.104.220.243.132) (Ping timeout: 256 seconds) [15:03:11] *** Joins: travis-ci (~travis-ci@ec2-54-161-124-150.compute-1.amazonaws.com) [15:03:12] (spdk/master) scripts: add gdb macros to print various spdk lists (shahar salzman) [15:03:12] Diff URL: https://github.com/spdk/spdk/compare/c1e0bded59d7...f4d6841ba3ea [15:03:12] *** Parts: travis-ci (~travis-ci@ec2-54-161-124-150.compute-1.amazonaws.com) () [15:15:11] *** Joins: thanosm (32c8b34a@gateway/web/freenode/ip.50.200.179.74) [15:23:44] *** Joins: jimharris (jimharris@nat/intel/x-lahsmgxjscybvumd) [15:23:45] *** ChanServ sets mode: +o jimharris [15:24:25] bwalker: looking at your "reactor contains a list of threads" patch [15:24:49] what if we added a TAILQ_ENTRY directly in spdk_thread? [15:24:59] that is available for applications to use [15:25:20] similar to how we put an extra TAILQ_ENTRY in spdk_bdev_io for bdev modules to use [15:27:18] *** Parts: michalwy (~michalwy@192.55.54.44) () [15:29:04] *** Joins: michalwy (~michalwy@192.55.54.44) [15:50:09] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [16:19:17] Besides, I want to fix the bug in the error log you said (https://review.gerrithub.io/#/c/spdk/spdk/+/443356/) [16:20:55] You kindly rebased the patch series, but I want to add the fix on top of the patch series. May I replace GPT patch by the error log fix patch and rebase the whole patch series again? [16:24:19] i think that would be ok Shuhei [16:24:36] it may run the patches through the test pool again but right now there is very little backlog in the queue [16:26:30] OK, I'll do. Thank you. [16:39:14] *** Joins: travis-ci (~travis-ci@ec2-54-92-222-250.compute-1.amazonaws.com) [16:39:15] (spdk/master) nvmf: use io unit size in transport buffer pools (Seth Howell) [16:39:15] Diff URL: https://github.com/spdk/spdk/compare/f4d6841ba3ea...bdc81134c20a [16:39:15] *** Parts: travis-ci (~travis-ci@ec2-54-92-222-250.compute-1.amazonaws.com) () [16:50:21] *** Quits: gila (~gila@5ED4D979.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [17:17:50] *** Quits: bwalker (~bwalker@134.134.139.83) (ZNC - http://znc.in) [17:18:16] *** Joins: bwalker_ (~bwalker@134.134.139.75) [17:18:16] *** ChanServ sets mode: +o bwalker_ [17:18:16] *** Server sets mode: +cnrt [17:18:16] *** Server sets mode: +cnrt [17:19:36] *** Quits: ppelplin (~ppelplin@134.134.139.83) (Remote host closed the connection) [17:19:37] *** Quits: spdk-jenkins-bot (~spdk-jenk@134.134.139.83) (Remote host closed the connection) [17:19:37] *** Quits: pawelkax (~pawelkax@134.134.139.83) (Remote host closed the connection) [17:19:37] *** Quits: sethhowe (~sethhowe@134.134.139.83) (Remote host closed the connection) [17:19:37] *** Quits: pniedzwx (~pniedzwx@134.134.139.83) (Remote host closed the connection) [17:20:03] *** Quits: peluse (~peluse@134.134.139.83) (Ping timeout: 245 seconds) [17:20:03] *** Quits: klateck (~klateck@134.134.139.83) (Ping timeout: 245 seconds) [17:20:26] *** Quits: mszwed (mszwed@nat/intel/x-hlmjjgnzidoaquwb) (Remote host closed the connection) [17:20:27] *** Quits: bwalker (~bwalker@134.134.139.83) (Remote host closed the connection) [17:20:53] *** Quits: jimharris (jimharris@nat/intel/x-lahsmgxjscybvumd) (Ping timeout: 245 seconds) [17:25:55] *** Joins: ppelplin (~ppelplin@134.134.139.75) [17:30:25] *** Joins: jimharris (jimharris@nat/intel/x-uutjuksxtxdtzvnf) [17:30:26] *** ChanServ sets mode: +o jimharris [17:31:51] *** Quits: michalwy (~michalwy@192.55.54.44) (Ping timeout: 244 seconds) [17:35:51] *** Joins: spdk-jenkins-bot (~spdk-jenk@134.134.139.75) [18:32:23] *** Quits: thanosm (32c8b34a@gateway/web/freenode/ip.50.200.179.74) (Ping timeout: 256 seconds) [18:58:48] *** Quits: zhouhui (~wzh@114.255.44.140) (Quit: WeeChat 1.9.1) [20:04:11] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 256 seconds) [20:51:07] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [22:42:17] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 256 seconds) [23:15:40] *** Joins: travis-ci (~travis-ci@ec2-184-72-93-125.compute-1.amazonaws.com) [23:15:41] (spdk/master) nvmf: add get/set features with reservation persistence support (Changpeng Liu) [23:15:42] Diff URL: https://github.com/spdk/spdk/compare/bdc81134c20a...da30cda946c1 [23:15:42] *** Parts: travis-ci (~travis-ci@ec2-184-72-93-125.compute-1.amazonaws.com) () [23:46:58] *** Joins: travis-ci (~travis-ci@ec2-54-82-70-96.compute-1.amazonaws.com) [23:46:59] (spdk/master) bdevperf: Fix incorrect error detection and log for IO size (Shuhei Matsumoto) [23:46:59] Diff URL: https://github.com/spdk/spdk/compare/da30cda946c1...8ad0935b816e [23:46:59] *** Parts: travis-ci (~travis-ci@ec2-54-82-70-96.compute-1.amazonaws.com) ()