[00:13:17] *** Joins: mszwed (~mszwed@134.134.139.72) [00:55:53] bwalker: ping https://review.gerrithub.io/c/spdk/spdk/+/425555 [11:05:06] sethhowe: I assume you've read my latest comment on 426129. Are you cogitating over next steps? Have something you're working on? Or, maybe would like to conference to discuss in greater detail? [11:07:41] Hi Lance, yeah, I thought about what you said. I think you are right. We should allow the user to choose how to link to env_dpdk. [11:11:12] lhodev: I am trying a couple things this morning related to reverting those explicit links from env_dpdk.so to our internal dpdk. [11:13:03] lhodev: the only thing I don't like about not linking the dpdk symbols into env_dpdk.so is that any customer who installs spdk will have to install dpdk libraries as well and explicitly link to them. It means that when we package, we will have to make sure we are in lockstep with dpdk. [11:15:01] lhodev: for example, on fc27, when I try to link an nvmf_tgt using gcc -o nvmf_tgt -lspdk -l spdk_env_dpdk -l dpdk, I get linker errors for undefined symbols because the packaged version of dpdk isn't up to date enough to have all the symbols. Which is fine, I just think that it limits us a little when packaging on distributions. [11:16:47] sethhowe: I'm of the opinion that the customer *should* have dpdk installed. In the pkg work Pawel is writing and I'm mostly reviewing/kibitzing, I can verify to you that the spdk spec file *does* explicitly call out requirement for the dpdk pkg(s). [11:18:37] I've also communicated to Pawel on the specific area of validating the *version* of the dpdk in the spec file. [11:20:21] lhodev: Ok, then not linking env_dpdk with the dpdk.a files fits into that model. I think that we should still not include env_dpdk and rte_vhost in the overarching specfile though so that they can specify their own environment library at that level as well. [11:21:38] I think that gives the user maximum flexibility. They can choose which version of dpdk they want to link against while still using env_dpdk or they can choose to implement their own custom env. Best of both worlds. [11:22:01] sethhowe: pwodkowx: Seth, I've not yet pulled Pawel's very latest spdk.spec file, but have included his IRC handle here to draw his attention to this discussion. [11:23:45] lhodev: good idea. I should look at his patches as well. [11:26:50] sethhowe: the wip spdk.spec file is at: https://review.gerrithub.io/#/c/spdk/spdk/+/424973/ [11:27:54] Note related to this effort are some changes to the build, so there's a chance there will be some merge efforts between your work and his. [11:54:45] pwodkowx, I knew there was a WIP button somewhere but it was hiding from me, found it now :) [12:19:28] OK, I give up. How do I remove the WIP? [12:20:29] peluse: I think I recall reading there's a "Ready" button to clear WIP....maybe? [12:20:55] oh, I found a button called 'start review' I dont recal seeing before, that seemed to do the trick [13:52:25] darsto: I see what you are doing in this one https://review.gerrithub.io/#/c/spdk/spdk/+/425700/ [13:52:33] but I'm concerned that's going to use so much memory [13:54:13] you're rounding up all allocations greater than 2MB to the next multiple of 2MB, if I'm understanding this correctly [14:27:39] sethhowe: Have you by chance had a chance to look at or run that script I shared with you to assist in identifying the inter-spdk lib dependencies ? [14:30:10] sethhowe, lhodev - any concerns if I merge the first patch in this shared lib series? [14:30:21] https://review.gerrithub.io/#/c/spdk/spdk/+/427807/ [14:31:26] jimharris: re-looking.... [14:33:22] jimharris: given that Seth just removed DPDK statics libs in the libspdk.so in 426129 in his latest patch set, that *might* obviate the need for 427807. sethhowe ? [14:36:38] *** Joins: travis-ci (~travis-ci@ec2-54-147-158-160.compute-1.amazonaws.com) [14:36:39] (spdk/master) configure: switch to arrays when generating CONFIG.local (Pawel Wodkowski) [14:36:39] Diff URL: https://github.com/spdk/spdk/compare/9a943bf8649c...577df16ab907 [14:36:39] *** Parts: travis-ci (~travis-ci@ec2-54-147-158-160.compute-1.amazonaws.com) () [14:36:41] lhodev: I think you are right there. [14:37:27] *** Joins: travis-ci (~travis-ci@ec2-54-147-158-160.compute-1.amazonaws.com) [14:37:28] (spdk/master) crypto: don't stop the examine process because of a claim error (paul luse) [14:37:28] Diff URL: https://github.com/spdk/spdk/compare/9938bfaf03ba...9a943bf8649c [14:37:28] *** Parts: travis-ci (~travis-ci@ec2-54-147-158-160.compute-1.amazonaws.com) () [14:38:08] jimharris: I will have to rebase the patch series without the first patch. That one is no longer needed after the most recent update. [14:38:14] ok - i'll mark the patch -1 for now [14:39:56] *** Joins: travis-ci (~travis-ci@ec2-54-80-214-77.compute-1.amazonaws.com) [14:39:57] (spdk/master) test/vhost: allow vm_setup to boot vm from vhost controller (Pawel Niedzwiecki) [14:39:57] Diff URL: https://github.com/spdk/spdk/compare/14bbde7bd4b8...b77ac822dc9c [14:39:57] *** Parts: travis-ci (~travis-ci@ec2-54-80-214-77.compute-1.amazonaws.com) () [14:44:21] *** Joins: travis-ci (~travis-ci@ec2-54-226-242-142.compute-1.amazonaws.com) [14:44:22] (spdk/master) bdev/raid: raid_bdev_add_base_devices: fix wrong param of spdk_strerror (wuzhouhui) [14:44:22] Diff URL: https://github.com/spdk/spdk/compare/b77ac822dc9c...d5132e871c76 [14:44:22] *** Parts: travis-ci (~travis-ci@ec2-54-226-242-142.compute-1.amazonaws.com) () [15:01:02] *** Joins: travis-ci (~travis-ci@ec2-54-162-85-101.compute-1.amazonaws.com) [15:01:03] (spdk/master) vhost_nvme: add support for bdev_io_wait implement (Ni Xun) [15:01:03] Diff URL: https://github.com/spdk/spdk/compare/d5132e871c76...b65b033758da [15:01:03] *** Parts: travis-ci (~travis-ci@ec2-54-162-85-101.compute-1.amazonaws.com) () [16:03:56] *** Joins: travis-ci (~travis-ci@ec2-54-162-222-77.compute-1.amazonaws.com) [16:03:57] (spdk/master) nvmf/rdma: Delay disconnect processing until connect processing is done (Ben Walker) [16:03:57] Diff URL: https://github.com/spdk/spdk/compare/b65b033758da...aaa691b0ce54 [16:03:57] *** Parts: travis-ci (~travis-ci@ec2-54-162-222-77.compute-1.amazonaws.com) () [16:04:40] *** Joins: travis-ci (~travis-ci@ec2-54-205-150-213.compute-1.amazonaws.com) [16:04:41] (spdk/master) configure: add concistency check of CONFIG file vs CONFIG[@] array (Pawel Wodkowski) [16:04:41] Diff URL: https://github.com/spdk/spdk/compare/aaa691b0ce54...48f70f48cfdf [16:04:41] *** Parts: travis-ci (~travis-ci@ec2-54-205-150-213.compute-1.amazonaws.com) () [16:06:01] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [16:13:02] *** Joins: travis-ci (~travis-ci@ec2-54-162-222-77.compute-1.amazonaws.com) [16:13:03] (spdk/master) Check file permissions in the check_format script (Ben Walker) [16:13:03] Diff URL: https://github.com/spdk/spdk/compare/48f70f48cfdf...d705ab93e1ac [16:13:03] *** Parts: travis-ci (~travis-ci@ec2-54-162-222-77.compute-1.amazonaws.com) () [16:18:53] lhodev: Sorry, I haven't gotten around to looking at the inter-spdk lib dependencies script yet. I just rebased my list of changes though, and I will pull it down now and give it a run. [16:21:05] lhodev: You uploaded the script to gerrithub right? I can't find the change. [16:22:25] sethhowe: Cool. Using the script, it should be -- I know, final words -- to update 426131 with the inter-spdk dependencies. [16:23:07] sethhowe: I stuffed the script in my own GitHub repo for you to clone. Still have that link? [16:25:06] lhodev: I seem to have misplaced it. Sorry, can you send it again? [16:25:51] sethhowe: https://github.com/lhoswdev/spdk_sideworks.git [16:26:01] Thank you! [16:37:14] *** Joins: travis-ci (~travis-ci@ec2-54-80-214-77.compute-1.amazonaws.com) [16:37:15] (spdk/master) vhost: rpc: add an optional parameter -n/--name for get_vhost_controllers (wuzhouhui) [16:37:15] Diff URL: https://github.com/spdk/spdk/compare/90051287d850...74a28c199f6d [16:37:15] *** Parts: travis-ci (~travis-ci@ec2-54-80-214-77.compute-1.amazonaws.com) () [17:07:03] *** Joins: travis-ci (~travis-ci@ec2-54-162-222-77.compute-1.amazonaws.com) [17:07:04] (spdk/master) bit_array: clarify initial bit values for create() (Jim Harris) [17:07:04] Diff URL: https://github.com/spdk/spdk/compare/74a28c199f6d...b3c330339d17 [17:07:04] *** Parts: travis-ci (~travis-ci@ec2-54-162-222-77.compute-1.amazonaws.com) () [20:06:31] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 256 seconds) [21:52:08] *** Quits: sethhowe (sethhowe@nat/intel/x-simsvaebfoscthow) (*.net *.split) [21:57:06] *** Joins: sethhowe (sethhowe@nat/intel/x-simsvaebfoscthow)