[01:45:26] Question about https://review.gerrithub.io/#/c/spdk/spdk/+/426037/ - this is a fix for ConfigShell needed by spdkcli in order to work with quoted params. Fix is based on a user code from ConfigShell github issues - it's simple and works for us. [01:46:00] Can anyone comment from legal perspective if we're allowed to use this piece of code? Source of fix is mentioned in commit message. [01:46:57] Pawel K. will probably create a pull request to Datera/ConfigShell repo with the fix, as original one is stuck in Github issues for over a year [02:06:48] *** Joins: travis-ci (~travis-ci@ec2-54-157-225-115.compute-1.amazonaws.com) [02:06:49] (spdk/master) bdev: Fix the second parameter `success` of spdk_bdev_io_completion_cb (Shuhei Matsumoto) [02:06:49] Diff URL: https://github.com/spdk/spdk/compare/1bc3837cdfc0...bc3dfe304354 [02:06:49] *** Parts: travis-ci (~travis-ci@ec2-54-157-225-115.compute-1.amazonaws.com) () [02:08:18] *** Joins: travis-ci (~travis-ci@ec2-54-159-226-178.compute-1.amazonaws.com) [02:08:19] (spdk/master) iscsi: update iscsi trace config (Liang Yan) [02:08:19] Diff URL: https://github.com/spdk/spdk/compare/bc3dfe304354...42db922de886 [02:08:19] *** Parts: travis-ci (~travis-ci@ec2-54-159-226-178.compute-1.amazonaws.com) () [02:09:21] *** Joins: travis-ci (~travis-ci@ec2-54-224-118-154.compute-1.amazonaws.com) [02:09:22] (spdk/master) doc/nvmf: add tracepoints user guide (John Kariuki) [02:09:22] Diff URL: https://github.com/spdk/spdk/compare/42db922de886...6c275b7a63c2 [02:09:22] *** Parts: travis-ci (~travis-ci@ec2-54-224-118-154.compute-1.amazonaws.com) () [02:20:00] *** Joins: travis-ci (~travis-ci@ec2-54-166-6-76.compute-1.amazonaws.com) [02:20:02] (spdk/master) test: Add check to bdevperf to fail if IO size is not a block multiple (Paul Luse) [02:20:02] Diff URL: https://github.com/spdk/spdk/compare/6c275b7a63c2...8e54e10c4f26 [02:20:02] *** Parts: travis-ci (~travis-ci@ec2-54-166-6-76.compute-1.amazonaws.com) () [02:20:08] mspaitn [02:20:14] oops:) [03:34:10] *** Joins: pawelkax (pawelkax@nat/intel/x-mmcnubvnjulkrszu) [03:34:50] Hi, I created pull request for configshell python library from Datera. [03:35:03] Link to it https://github.com/Datera/configshell/pull/4/commits. [03:35:12] If it is merged then we won't need patch https://review.gerrithub.io/#/c/426037/. [04:45:42] The patch for configshell I created should solve issue https://github.com/Datera/configshell/issues/2 [06:20:36] *** Quits: lhodev (~lhodev@inet-hqmc01-o.oracle.com) (Remote host closed the connection) [06:31:45] pawelkax: I think you can get no response from them. This repo look like be unmaintained. I think you shoild go for https://github.com/agrover/configshell-fb [06:48:29] *** Joins: lhodev (~lhodev@66-90-218-190.dyn.grandenetworks.net) [06:57:19] I added github issue in https://github.com/open-iscsi/configshell-fb/issues/46 [08:36:49] klateck, pawelkax: how do you want to move forward with 426037? [08:42:29] *** Joins: travis-ci (~travis-ci@ec2-54-235-30-28.compute-1.amazonaws.com) [08:42:30] (spdk/master) bdev/raid: Add .INI config dump (Shuhei Matsumoto) [08:42:30] Diff URL: https://github.com/spdk/spdk/compare/8e54e10c4f26...ef8047033825 [08:42:30] *** Parts: travis-ci (~travis-ci@ec2-54-235-30-28.compute-1.amazonaws.com) () [09:03:10] what's the general license on configshell? [09:03:18] that's the assumed to be the license for proposed patches [09:23:45] Apache 2 [09:27:25] so if we check it into our repository, we at least need to tag it with that license [10:55:02] peluse: is there a community meeting in ~10 hours? [10:55:22] you used to shout here if it was there [10:55:33] i can't remember what day today is :) probably so [10:56:18] yeah, its tonight - the APA series [10:56:22] APAC [10:56:36] I'll go make sure we have a trello agenda up there... [10:57:21] yup, its there.. https://trello.com/b/DvM7XayJ/spdk-community-meeting-agenda [11:05:44] jimharris, I got rid of the single mempool_puts in the poller loop and now after the loop do 2 bulk_puts (one for mbufs and one for crypto ops) and vishal's data is much, much better. Good call! Gotta go run some errands, etc., will clean it up and submit patch later.... [11:21:25] paluse, darsto: about https://review.gerrithub.io/#/c/426931/ [11:22:38] I think we shoudl just add -lIPSec_MB.a to bdev_crypto [11:22:59] and in dpdkbuld/Makegile add and -L$(SPDK_ROOT_DIR)/intel-ipsec-mb [11:23:12] yep - that will work too [11:23:14] instead hardocing $(SPDK_ROOT_DIR)/intel-ipsec-mb/libIPSec_MB.a [11:31:29] darsto: which patches you want to be reviewed first? there are so many of them :P [11:36:17] pwodkowx: probably the latest ones :) [11:47:11] pwodkowx, if we specify -L /path/to/ipsec, then how can we predict which libIPSec_MB.a will be used? [11:47:33] there may be another one from the system libs [11:52:36] man ld: -L option: Directories specified on the command line are searched before [11:52:36] the default directories. [11:52:57] ok [11:54:33] does ipsec cause any troubles for now in terms of packaging? [11:55:10] for now bdev_crypto is disabled in package generation but it will be enabled eventually [11:55:52] any idea how dpdk handles it? [11:55:54] I have another problem to solve: need to remove $(SPDK_ROOT_DIR) from all makefiles... [11:56:16] ugh - why is that? [11:56:44] examples package is broken [11:57:28] it looks for $(SPDK_ROOT_DIR) that was set during SPDK build instead /usr/include [11:57:37] pwodkowx: perhaps that's why the dpdk-devel pkg installs that script that sets env variables. [12:01:27] in my mind - these env variables are for lazy developers otherwise each *-devel package would do the same. And they don't do that. [12:02:32] pwodkowx: Agreed. It'd be an ugly mess if all -devel packages polluted (um, populated ;-) ) /etc/profile.d [12:03:21] we only need to adjust our build system to detect proper location of headers. I hope this will be only thing that is needed to build our example out of tree. [12:03:32] otherwise I will add poinson to my morning coffe... [12:05:07] Is there a Polish equivalent to "Irish coffee"; i.e. with alcohol instead of poison? ;-) [12:05:20] it's called vodka [12:07:30] lol. Duly noted. [12:09:17] hmmm... this is an idea. but I will skip coffee part and use only alcohol :D [12:15:31] jimharris: in dpdk/drivers/crypto/aesni_gcm/Makefile: it is just adding -lIPSecMB to LDFLAGS. I think they require right version to be in default linker search path. [12:27:06] i guess i meant does the dpdk package have a dependency on ipsecmb? [12:38:35] jimharris: when I scan through the dpdk spec file, I see no BuildRequires or Requires for anything remotely ipsec. [12:38:58] Also tried rpmfind.net to scan for a pkg containing libipsecmb.a. Nada. [12:45:13] that's what i figured [14:01:10] *** Joins: travis-ci (~travis-ci@ec2-54-145-246-225.compute-1.amazonaws.com) [14:01:11] (spdk/master) Makefile: add ifdef guards to config.h (Pawel Wodkowski) [14:01:12] Diff URL: https://github.com/spdk/spdk/compare/ef8047033825...55bc3a725550 [14:01:12] *** Parts: travis-ci (~travis-ci@ec2-54-145-246-225.compute-1.amazonaws.com) () [14:07:03] *** Joins: travis-ci (~travis-ci@ec2-54-145-179-66.compute-1.amazonaws.com) [14:07:04] (spdk/master) test/vhost: fix vhost live migration tc2 & tc3 (Pawel Niedzwiecki) [14:07:04] Diff URL: https://github.com/spdk/spdk/compare/6820641a5d88...8f89a679ae10 [14:07:04] *** Parts: travis-ci (~travis-ci@ec2-54-145-179-66.compute-1.amazonaws.com) () [14:10:08] *** Joins: travis-ci (~travis-ci@ec2-54-91-191-72.compute-1.amazonaws.com) [14:10:09] (spdk/master) doc/vagrant.md: update vagrant docs (Vitaliy Mysak) [14:10:09] Diff URL: https://github.com/spdk/spdk/compare/8f89a679ae10...03f2a4634c91 [14:10:09] *** Parts: travis-ci (~travis-ci@ec2-54-91-191-72.compute-1.amazonaws.com) () [14:54:51] jimharris: When I upgraded fedora-06 to FC28, I introduced a latent failure in the RPC NVMe-oF tests which I believe https://review.gerrithub.io/c/spdk/spdk/+/426772 fixes. Here is an example of the latent failure. https://ci.spdk.io/spdk/builds/review/4697e36d15f6c397ae784271b67ed22c958eb32d.1537971953/fedora-06/build.log [14:58:43] cool [14:58:51] i +2'd and pushed it [15:01:38] *** Joins: travis-ci (~travis-ci@ec2-54-196-216-13.compute-1.amazonaws.com) [15:01:40] (spdk/master) test/nvmf: add waitforblk calls to rpc tests. (Seth Howell) [15:01:40] Diff URL: https://github.com/spdk/spdk/compare/1e4f9974a702...713b48179676 [15:01:40] *** Parts: travis-ci (~travis-ci@ec2-54-196-216-13.compute-1.amazonaws.com) () [18:34:29] *** Joins: travis-ci (~travis-ci@ec2-54-145-179-66.compute-1.amazonaws.com) [18:34:30] (spdk/master) ocssd: add chunk notification log struct (Jakub Radtke) [18:34:30] Diff URL: https://github.com/spdk/spdk/compare/713b48179676...9bb97528819c [18:34:30] *** Parts: travis-ci (~travis-ci@ec2-54-145-179-66.compute-1.amazonaws.com) ()