[00:28:03] *** Quits: peluse (~peluse@134.134.139.72) (Ping timeout: 256 seconds) [00:28:28] *** Quits: sethhowe (sethhowe@nat/intel/x-fnxgbjqibvjscjwk) (Ping timeout: 272 seconds) [00:38:37] *** Joins: pzedlews (~pzedlews@134.134.139.72) [00:40:08] *** Joins: klateck (klateck@nat/intel/x-lpxwcsywlpekexme) [00:41:30] *** Joins: ppelplin (~ppelplin@134.134.139.72) [00:59:14] *** Joins: tkulasek (~tkulasek@134.134.139.76) [02:20:35] *** Quits: mbjorling (~silverwol@95-166-82-66-cable.dk.customer.tdc.net) (Ping timeout: 240 seconds) [04:07:54] *** Quits: nKumar (sid239884@gateway/web/irccloud.com/x-vlrtzrsjbeojxrev) (Quit: Connection closed for inactivity) [06:55:56] *** Quits: alekseymmm (050811aa@gateway/web/freenode/ip.5.8.17.170) (Quit: Page closed) [07:01:55] bwalker: shouldn't nvme_rdma_mr_map_notify() be somehow synchronized with qpair destruction? [07:05:25] nevermind, we synchronize creating and destroying the mem_map, which should be enough [07:07:36] *** Joins: alekseymmm (050811aa@gateway/web/freenode/ip.5.8.17.170) [07:31:25] *** Joins: travis-ci (~travis-ci@ec2-54-225-16-159.compute-1.amazonaws.com) [07:31:26] (spdk/master) jsoncat, histogram_perf: add missing dependencies (Jim Harris) [07:31:26] Diff URL: https://github.com/spdk/spdk/compare/9ee494213087...e7c9f620460d [07:31:26] *** Parts: travis-ci (~travis-ci@ec2-54-225-16-159.compute-1.amazonaws.com) () [08:14:13] *** Joins: bwalker_ (~bwalker@ip70-190-226-244.ph.ph.cox.net) [08:14:13] *** ChanServ sets mode: +o bwalker_ [08:23:10] peluse: WebEx meetings all updated with the correct upper case password [08:23:33] bwalker, bwalker_: could you review my bdev cleanup series if you get a chance this morning? [08:25:55] *** Joins: travis-ci (~travis-ci@ec2-54-225-16-159.compute-1.amazonaws.com) [08:25:56] (spdk/master) vhost-blk: put bdev IO channel on hot remove (Maciej Szwed) [08:25:56] Diff URL: https://github.com/spdk/spdk/compare/e7c9f620460d...039a4c6cb0f0 [08:25:56] *** Parts: travis-ci (~travis-ci@ec2-54-225-16-159.compute-1.amazonaws.com) () [08:28:22] reviewing it now [09:00:10] *** Joins: bluebird (~bluebird@p5DE94E9A.dip0.t-ipconnect.de) [09:09:06] lhodev: looking at your patches - i'm curious, why did you need to change the OSTYPE/FreeBSD comparison? did that not work how it was before? [09:19:03] *** Quits: tkulasek (~tkulasek@134.134.139.76) (Remote host closed the connection) [09:26:41] pwodkowx: could you take a look? https://review.gerrithub.io/c/spdk/spdk/+/422582 [09:27:33] it should also fix your old virtio<->vhost<->virtio scenario [09:32:05] lhodev: never mind - it certainly doesn't work as before [09:32:52] *** Quits: bwalker_ (~bwalker@ip70-190-226-244.ph.ph.cox.net) (Quit: Leaving) [09:52:41] *** Joins: travis-ci (~travis-ci@ec2-54-226-101-102.compute-1.amazonaws.com) [09:52:42] (spdk/master) scripts/vagrant: add configuration for vhost tests (Karol Latecki) [09:52:42] Diff URL: https://github.com/spdk/spdk/compare/039a4c6cb0f0...9a361ac01dfd [09:52:42] *** Parts: travis-ci (~travis-ci@ec2-54-226-101-102.compute-1.amazonaws.com) () [10:10:04] jimharris: sorry, stepped away. Yeah, I was surprised to find that OSTYPE comparison not functioning the way as originally intended. [10:10:10] *** Joins: travis-ci (~travis-ci@ec2-54-226-101-102.compute-1.amazonaws.com) [10:10:11] (spdk/v18.07.x) SPDK 18.07 (Ben Walker) [10:10:11] Diff URL: https://github.com/spdk/spdk/compare/v18.07.x [10:10:11] *** Parts: travis-ci (~travis-ci@ec2-54-226-101-102.compute-1.amazonaws.com) () [10:11:19] we were comparing against FreeBSD when it clearly should have been freebsd [10:16:10] Will you thusly undo the review -1 on https://review.gerrithub.io/#/c/spdk/spdk/+/422307/ ? [10:17:02] changing FreeBSD to freebsd is OK - I'm not following why we need to do ${OSTYPE,freebsd} instead of just $OSTYPE though [10:17:47] Just in case there's any case-stuff in OSTYPE, that operator will force the case to lower for all those letters ensuring that the get a good compare. [10:22:43] At least that's how I thought that bash'ism worked. Lemme revisit. [10:22:51] I don't think that's how it works [10:22:57] at least I don't see that working on my system [10:23:51] i think just reverting to use just $OSTYPE in your patch would be best (but still keeping the FreeBSD => freebsd change) [10:23:57] Well, rather than continue to mess with that "enhancement", I'll just revert it, albeit with the compare to "freebsd", for the sake of expediency. [10:24:30] sounds good [10:29:19] fixed/pushed [12:01:32] *** Quits: bluebird (~bluebird@p5DE94E9A.dip0.t-ipconnect.de) (Quit: Leaving) [14:13:22] *** Joins: travis-ci (~travis-ci@ec2-54-226-101-102.compute-1.amazonaws.com) [14:13:23] (spdk/master) setup.sh: cleanup any leftover DPDK files (Dariusz Stojaczyk) [14:13:23] Diff URL: https://github.com/spdk/spdk/compare/8f186a81c5db...1469679f0930 [14:13:23] *** Parts: travis-ci (~travis-ci@ec2-54-226-101-102.compute-1.amazonaws.com) () [17:24:56] *** Joins: peluse (peluse@nat/intel/x-ztzgkgdgpvivxgfo) [17:24:56] *** ChanServ sets mode: +o peluse [17:28:22] so crypto should be ready to run through CI now, I just need to make the changes to make with --with-crypto in the test infra. How do we want to do this, enable it on all test systems all of the time? Can't remember what we talked about its been sooooo long :) [17:29:30] I think we add an SPDK_TEST_CRYPTO option in autotest.sh [17:29:39] and then set that on some subset of systems in the test pool [17:30:02] I saw the check format script complained because of no space before the */ in a comment [17:34:34] I thought I fixed that one [17:34:54] local check_script found one and I fixed before I submitted [17:37:59] jimharris, where are you lookin? [17:41:24] on my latest patch, w/o the autotest changes, it should have passed. Both Jenkins and CH pool failed on a Doxygen thing [17:41:45] oh, my doxygen thing, LOL. [17:47:19] forgot to add my .md file to Doxyfile... I'll let it pass once w/o enabling crypto, then will add the option. So I suppose I'll need to set the option, submit, then unset it and resubmit once I know it passes then have it set on a subset of machines how/where? [22:28:43] *** Joins: waelhalbawi (6b03a57c@gateway/web/freenode/ip.107.3.165.124) [22:34:19] *** Quits: waelhalbawi (6b03a57c@gateway/web/freenode/ip.107.3.165.124) (Quit: Page closed)