[00:42:20] *** Quits: y4m4 (490fb8f3@gateway/web/cgi-irc/kiwiirc.com/ip.73.15.184.243) (Ping timeout: 245 seconds) [02:14:48] *** Quits: darsto (~darsto@89-68-114-161.dynamic.chello.pl) (Ping timeout: 264 seconds) [02:18:49] *** Joins: darsto (~darsto@89-68-114-161.dynamic.chello.pl) [03:01:20] *** Joins: darsto_ (~darsto@89-68-114-161.dynamic.chello.pl) [03:02:07] *** Quits: darsto (~darsto@89-68-114-161.dynamic.chello.pl) (Ping timeout: 245 seconds) [03:02:07] *** darsto_ is now known as darsto [04:20:27] *** Quits: dlw (~Thunderbi@114.255.44.143) (Ping timeout: 240 seconds) [04:26:25] *** Joins: lyan (~lyan@2605:a000:160e:2124:4a4d:7eff:fef2:eea3) [04:26:49] *** lyan is now known as Guest52785 [06:34:31] *** Joins: mowais (9353c962@gateway/web/freenode/ip.147.83.201.98) [06:38:57] *** Quits: mowais (9353c962@gateway/web/freenode/ip.147.83.201.98) (Ping timeout: 252 seconds) [06:40:34] *** Joins: philipp-sk (~Philipp@ktnron0916w-lp130-02-76-66-162-159.dsl.bell.ca) [08:44:15] *** Quits: tomzawadzki (~tomzawadz@192.55.54.42) (Ping timeout: 268 seconds) [09:00:58] *** Joins: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) [10:54:21] *** Quits: sethhowe (~sethhowe@134.134.139.72) (Remote host closed the connection) [10:57:13] *** Joins: sethhowe (~sethhowe@134.134.139.72) [11:32:03] Can someone please review my patches at: https://review.gerrithub.io/#/c/spdk/spdk/+/414861/ [11:56:23] *** Quits: sage_ (~quassel@2607:f298:5:101d:f816:3eff:fe21:1966) (Ping timeout: 276 seconds) [11:57:29] *** Joins: travis-ci (~travis-ci@ec2-54-162-137-41.compute-1.amazonaws.com) [11:57:30] (spdk/master) ocssd: add chunk info list as mptr of vector reset (Young Tack Jin) [11:57:30] Diff URL: https://github.com/spdk/spdk/compare/09e3f4e3db2c...6d05186697f9 [11:57:30] *** Parts: travis-ci (~travis-ci@ec2-54-162-137-41.compute-1.amazonaws.com) () [11:57:46] *** Joins: sage_ (~quassel@2607:f298:5:101d:f816:3eff:fe21:1966) [12:10:45] *** Joins: travis-ci (~travis-ci@ec2-54-145-84-116.compute-1.amazonaws.com) [12:10:46] (spdk/master) lib: validate ib_verbs context is valid before using it (shahar salzman) [12:10:47] Diff URL: https://github.com/spdk/spdk/compare/6d05186697f9...a0246f655339 [12:10:47] *** Parts: travis-ci (~travis-ci@ec2-54-145-84-116.compute-1.amazonaws.com) () [12:28:07] sethhowe: https://review.gerrithub.io/#/c/spdk/spdk/+/418236/ [12:29:16] johnmeneghini: i'll retry your latest vagrant patch [12:39:04] Thanks Jim [12:39:26] jimharris: thanks for the notice. [12:52:28] *** Joins: alekseymmm (050811aa@gateway/web/freenode/ip.5.8.17.170) [13:12:02] sethhowe/drv: could you also look at https://review.gerrithub.io/#/c/spdk/spdk/+/416052/ [13:12:57] the qemu configuration in vm_setup.sh can be simplified, but i'd like to get this in since we've already forced johnmeneghini to painfully rebase this patch [13:12:59] all of these tests are using an extra subshell and then throwing the results away - not sure how much we care [13:13:27] e.g. if [ $(echo $CONF | grep tsocks) ] could just be if [ echo $CONF | grep -q tsocks ] [13:13:38] I'll look at the qemu configuration. [13:13:39] or probably more efficiently written using builtin bash regex [13:14:08] what is the --allowerasing allowing in the openssl installation? [13:14:20] does it have to remove some other package to let that work? [13:16:01] it's a vpp thing - we'll need tomek to weigh in [13:16:13] The —allowerasing stuff is to make vm_setup.sh and pkgdep.sh idempotent. Once you run vm_setup.sh -t vpp, the openssl package installed by pgkdep.sh is erased. [13:16:14] but i don't think what john has is any worse than what was already there [13:16:53] the VPP install should probably put things back the way they were if that's possbile [13:16:59] So, in order to support running pkgdep.sh after vm_setup.sh, you need to allow erasing [13:17:13] but we can fix that up later, I suppose, as long as it doesn't break the system... [13:17:18] Sure… that would be another improvement. [13:17:20] agree but i think that's outside of john's patch [13:18:07] john - if you're going to fix the qemu configure stuff, could you also make the other changes that drv suggested? [13:18:29] e.g. if [ $(echo $CONF | grep tsocks) ] could just be if [ echo $CONF | grep -q tsocks ] [13:18:38] actually, it can be even simpler - get rid of the test entirely [13:18:44] if echo $CONF | grep -q tsocks; [13:19:48] drv: can you make a comment in gerrit with this (just want to make sure it doesn't get lost) [13:19:54] yes [13:27:37] johnmeneghini: posted a comment on why the $git_param wasn't working for you [13:42:36] *** Quits: gila (~gila@5ED74129.cm-7-8b.dynamic.ziggo.nl) (Quit: Textual IRC Client: www.textualapp.com) [13:42:39] drv: how can we get rid of "f echo $CONF | grep -q tsocks" Please suggest the bash regex that will be better [13:43:28] I don't know the bash regex syntax off the top of my head, but I think it's something like if [ var =~ pattern ] [13:43:43] it might be best to just stick with the echo | grep checks like you have now [13:44:00] but taking it out of the $()? [13:44:15] so [ echo $CONF | grep -q tsocks ] [13:44:15] yes [13:44:17] no [13:44:22] if echo $CONF | grep -q tsocks [13:44:25] no brackets [13:44:46] OK. I'll make that change. [13:44:52] thanks [14:05:59] *** Quits: alekseymmm (050811aa@gateway/web/freenode/ip.5.8.17.170) (Quit: Page closed) [14:18:38] *** Joins: peter_turschm (~peter_tur@66.193.132.66) [14:18:43] *** Quits: peter_turschm (~peter_tur@66.193.132.66) (Remote host closed the connection) [14:19:06] *** Joins: peter_turschm (~peter_tur@66.193.132.66) [14:20:43] Is this the right channel for asking SPDK code questions? [14:21:07] yep [14:21:24] Sweet. [14:24:44] I think we talked about the dynamic hugepage improvement to DPDK at the meetup. Does the release note in https://github.com/spdk/dpdk/commit/e853dbb8b23a697b4dfac48cb3d5bad16c7932b6 describe what you were talking about? [14:26:18] those are the DPDK changes, yes [14:26:34] darsto is working on SPDK changes to take advantage of this new memory allocation strategy [14:27:17] I think this is new in dpdk-18.05 but there doesn't seem to be an associated spdk-18.04 so I've been trying to get the 2 to work together. However I seem to be getting blocked when probing the NVMe devices because they don't have a driver that seems compatible with the flag RTE_PCI_DRV_NEED_MAPPING. [14:27:22] Oh nice! [14:27:51] we did an 18.04.1 release that works with dpdk-18.05, but it only works because it reverts to the original memory allocation strategy [14:28:12] there were some fundamental assumptions changed when moving to the new allocation regarding contiguous memory allocations [14:29:07] gotcha [14:29:16] https://review.gerrithub.io/#/q/owner:dariuszx.stojaczyk%2540intel.com+status:open [14:29:25] that's all of darsto's open patches - ignore the vhost ones [14:29:28] most of the rest are related to this [14:30:43] Sweet. Are those patches relatively stable for now? Not looking to use it in production, mostly interested in testing. [14:31:12] we'd have to wait for darsto to weigh in - I don't think they're all in a single series though [14:31:25] cool [14:35:27] drv: Why can't I get this code to work? This is all about evaluating single and double quotes in the bash expression. [14:35:30] git_param="--prefix=/usr/local/qemu/$SPDK_QEMU_BRANCH" [14:35:31] [14:35:31] # Most tsocks proxies rely on a configuration file in /etc/tsocks.conf. [14:35:31] # If using tsocks, please make sure to complete this config before trying to build qemu. [14:35:31] if echo $CONF | grep tsocks; then [14:35:31] if hash tsocks 2> /dev/null; then [14:35:31] git_param="--prefix=/usr/local/qemu/$SPDK_QEMU_BRANCH --with-git='tsocks git'" [14:35:32] fi [14:35:32] fi [14:35:33] set -xv [14:35:33] ./configure ${git_param} --target-list="x86_64-softmmu" --enable-kvm --enable-linux-aio --enable-numa [14:35:57] + ./configure --prefix=/usr/local/qemu/spdk-2.12-pre '--with-git='\''tsocks' 'git'\''' --target-list=x86_64-softmmu --enable-kvm --enable-linux-aio --enable-numa [14:35:57] ERROR: unknown option git' [14:35:57] Try './configure --help' for more information [14:36:43] because you're passing ${git_param} unquoted, it will get expanded to multiple arguments [14:37:21] are some cases where we don't set --prefix? [14:39:32] I don't think scripts/genconfig.py in the configure script takes a prefix. [14:39:40] Or I missed something. [14:40:15] No prefix is always set. [14:40:26] I think this is configuring qemu inside vm_setup.sh, not configuring SPDK [14:41:01] Yes, I am, tallking about configuring qemu [14:41:29] drv: thanks for the help. [14:41:32] This worked. [14:41:34] git_param="--prefix=/usr/local/qemu/$SPDK_QEMU_BRANCH" [14:41:34] [14:41:34] # Most tsocks proxies rely on a configuration file in /etc/tsocks.conf. [14:41:34] # If using tsocks, please make sure to complete this config before trying to build qemu. [14:41:34] if echo $CONF | grep tsocks; then [14:41:34] if hash tsocks 2> /dev/null; then [14:41:34] git_param="--prefix=/usr/local/qemu/$SPDK_QEMU_BRANCH --with-git='tsocks git'" [14:41:35] fi [14:41:35] fi [14:41:36] set -xv [14:41:36] ./configure "${git_param}" --target-list="x86_64-softmmu" --enable-kvm --enable-linux-aio --enable-numa [14:42:05] more quotes is always the answer with bash [14:43:17] drv: saw your comment on Tomek's patch - he probably should have switched that patch with the one after it [14:43:50] does the next one fix up the error handling? [14:43:57] the one after it uses bdev_io_wait in the scsi layer (including reset) [14:44:02] ah, ok [14:44:57] I see that now [14:45:08] I'm ok with it as long as we check in the pair together [14:45:23] that's the plan [14:49:45] OK. My patch series has been updated. I need to leave and pick up my kid from work now. Be back later. [14:49:46] remote: Updated Changes: [14:49:46] remote: https://review.gerrithub.io/#/c/spdk/spdk/+/414861 test: add support for multiple oses with vagrant [14:49:46] remote: https://review.gerrithub.io/#/c/spdk/spdk/+/416052 test: improvements to vm_setup.sh and pkgdep.sh [14:49:46] remote: https://review.gerrithub.io/#/c/spdk/spdk/+/418236 test: vm_setup.sh localization [14:50:36] peter_turschm: i uploaded them once some time ago and am now rebasing them one by one [14:50:49] so you may have trouble trying to apply all of them [14:52:46] Thanks darsto. I read through them and I'll try that in a bit. I think my current error might be a more fundamental config issue. [14:53:16] bwalker: can you take a look at the InCapsuleDataSize 0 patch? https://review.gerrithub.io/#/c/spdk/spdk/+/418170/ [14:54:43] peter_turschm: make sure to apply the dpdk patches though. At the beginning I wasn't even able to exit from eal_init() without an error [14:55:10] those are all in one series and got acked by Anatoly already [14:57:38] darsto: I think my problem is that I don't have VFIO support compiled into SPDK. During the EAL probe I have an NVMe driver configured with vfio as the driver, but it's still ignored as unsupported. [15:27:46] *** Joins: travis-ci (~travis-ci@ec2-54-224-42-206.compute-1.amazonaws.com) [15:27:47] (spdk/master) test/nvmf: test InCapsuleDataSize 0 in filesystem.sh (Daniel Verkamp) [15:27:48] Diff URL: https://github.com/spdk/spdk/compare/df8cbd66c725...1fcfc425bf1b [15:27:48] *** Parts: travis-ci (~travis-ci@ec2-54-224-42-206.compute-1.amazonaws.com) () [15:55:50] *** Joins: dlw (~Thunderbi@114.246.82.173) [16:22:22] *** Joins: sethhowe_ (sethhowe@nat/intel/session) [16:23:00] *** Quits: sethhowe (~sethhowe@134.134.139.72) (Remote host closed the connection) [16:24:20] *** Quits: sethhowe_ (sethhowe@nat/intel/session) (Changing host) [16:24:21] *** Joins: sethhowe_ (sethhowe@nat/intel/x-uvvumoidkzsvgjvr) [16:26:25] *** Quits: dlw (~Thunderbi@114.246.82.173) (Ping timeout: 244 seconds) [16:29:21] *** Quits: Guest52785 (~lyan@2605:a000:160e:2124:4a4d:7eff:fef2:eea3) (Quit: Leaving) [16:59:55] *** Joins: dlw (~Thunderbi@114.246.82.173) [17:31:33] *** Quits: peter_turschm (~peter_tur@66.193.132.66) (Remote host closed the connection) [17:47:29] *** Quits: dlw (~Thunderbi@114.246.82.173) (Ping timeout: 260 seconds) [18:05:49] *** Joins: travis-ci (~travis-ci@ec2-54-162-137-41.compute-1.amazonaws.com) [18:05:50] (spdk/master) test/nvme: add unit test cases for nvme_qpair.c (Chen Wang) [18:05:51] Diff URL: https://github.com/spdk/spdk/compare/1fcfc425bf1b...87210c139134 [18:05:51] *** Parts: travis-ci (~travis-ci@ec2-54-162-137-41.compute-1.amazonaws.com) () [18:56:56] *** Joins: dlw (~Thunderbi@114.255.44.143) [19:07:32] *** Quits: johnmeneghini (~johnmeneg@pool-100-0-53-181.bstnma.fios.verizon.net) (Quit: Leaving.) [19:14:14] *** Joins: peluse- (~peluse@134.134.139.72) [19:15:38] *** Joins: tsg_ (~tsg@134.134.139.72) [19:16:10] *** Joins: mszwed_ (mszwed@nat/intel/session) [19:19:22] *** Quits: ppelplin (~ppelplin@134.134.139.72) (Ping timeout: 240 seconds) [19:19:22] *** Quits: pbshah1 (pbshah1@nat/intel/x-hstceafgagwtyntr) (Ping timeout: 240 seconds) [19:19:30] *** Quits: mszwed (mszwed@nat/intel/x-cxlprfyamjuzqofp) (Ping timeout: 260 seconds) [19:19:30] *** Quits: tsg (~tsg@134.134.139.72) (Ping timeout: 260 seconds) [19:19:31] *** Quits: peluse (~peluse@134.134.139.72) (Ping timeout: 260 seconds) [19:19:35] *** Quits: mszwed_ (mszwed@nat/intel/session) (Changing host) [19:19:35] *** Joins: mszwed_ (mszwed@nat/intel/x-tmmdlxvdefisjbtz) [19:19:35] *** tsg_ is now known as tsg [19:19:35] *** peluse- is now known as peluse [19:20:06] *** mszwed_ is now known as mszwed [19:31:16] *** Joins: ppelplin (~ppelplin@134.134.139.72) [19:32:01] *** Joins: pbshah1 (~pbshah1@134.134.139.72) [20:25:20] *** Quits: philipp-sk (~Philipp@ktnron0916w-lp130-02-76-66-162-159.dsl.bell.ca) (Ping timeout: 276 seconds) [23:41:25] *** Joins: tomzawadzki (tomzawadzk@nat/intel/x-xljwmlnxhxglprwu)