[00:55:39] *** Joins: alekseymmm (bcf3adf1@gateway/web/freenode/ip.188.243.173.241) [01:18:16] *** Quits: pohly (~pohly@p5484976F.dip0.t-ipconnect.de) (Quit: Leaving.) [02:44:59] *** Quits: alekseymmm (bcf3adf1@gateway/web/freenode/ip.188.243.173.241) (Ping timeout: 260 seconds) [04:54:35] *** Joins: darsto_ (~darsto@89-68-132-204.dynamic.chello.pl) [04:56:25] *** Quits: darsto (~darsto@89-64-41-182.dynamic.chello.pl) (Ping timeout: 268 seconds) [04:56:25] *** darsto_ is now known as darsto [05:23:39] *** Joins: darsto_ (~darsto@89-68-132-204.dynamic.chello.pl) [05:24:40] *** Quits: darsto (~darsto@89-68-132-204.dynamic.chello.pl) (Ping timeout: 240 seconds) [05:24:40] *** darsto_ is now known as darsto [05:35:45] *** Joins: darsto_ (~darsto@89-68-132-204.dynamic.chello.pl) [05:36:46] *** Quits: darsto (~darsto@89-68-132-204.dynamic.chello.pl) (Ping timeout: 260 seconds) [05:36:46] *** darsto_ is now known as darsto [05:55:20] *** Joins: pohly (~pohly@p5484976F.dip0.t-ipconnect.de) [06:21:20] *** Quits: pohly (~pohly@p5484976F.dip0.t-ipconnect.de) (Quit: Leaving.) [09:23:29] *** Joins: alekseymmm (bcf3adf1@gateway/web/freenode/ip.188.243.173.241) [09:50:50] Hello [09:51:22] What was the idea behind moving bdev_io fields to intersnal struct of bdev_io ? [10:53:41] It seems no one here) [11:31:12] *** Joins: pohly (~pohly@p5484976F.dip0.t-ipconnect.de) [11:39:31] *** Quits: pohly (~pohly@p5484976F.dip0.t-ipconnect.de) (Quit: Leaving.) [11:54:30] *** Quits: alekseymmm (bcf3adf1@gateway/web/freenode/ip.188.243.173.241) (Ping timeout: 260 seconds) [12:33:27] *** Joins: alekseymmm (bcf3adf1@gateway/web/freenode/ip.188.243.173.241) [12:48:19] *** Joins: pohly (~pohly@p5484976F.dip0.t-ipconnect.de) [13:56:56] *** Quits: pohly (~pohly@p5484976F.dip0.t-ipconnect.de) (Quit: Leaving.) [14:19:21] alekseymmm: it's saturday after all :) [14:19:39] the plan was to make these fields "private" to bdev modules [14:20:46] just so nobody is tempted to touch those when developing a new bdev module [14:26:28] here, check this patch: https://review.gerrithub.io/c/spdk/spdk/+/412298 [14:26:40] i believe that's when all this encapsulating started [14:49:03] Ok but what about the field cb , and the fact that there is bdev_io->u.bdev.stored_user_cb . So it seems like we have a possibility to save callbac and restore it later [14:49:27] but if it is private then it is likely a contradiction [14:50:25] Yea I saw some patches that incapsulate this fields [15:41:47] I don't thing you need to modify bdev_io from within bdev modules [15:41:58] the API that sets up bdev_io should be enough [15:43:10] do you have any particular concern/use-case that the current interface doesn't cover? [16:13:58] *** Quits: alekseymmm (bcf3adf1@gateway/web/freenode/ip.188.243.173.241) (Quit: Page closed)