[00:20:33] *** Joins: dlw (~Thunderbi@114.255.44.143) [04:26:03] *** Joins: dlw1 (~Thunderbi@114.255.44.143) [04:26:03] *** Quits: dlw (~Thunderbi@114.255.44.143) (Read error: Connection reset by peer) [04:26:04] *** dlw1 is now known as dlw [06:11:14] *** Quits: dlw (~Thunderbi@114.255.44.143) (Remote host closed the connection) [06:11:34] *** Joins: dlw (~Thunderbi@114.255.44.143) [08:52:44] bwalker: can you review https://review.gerrithub.io/#/c/spdk/spdk/+/406919/ [08:52:56] or drv (i think you're back today?) [09:06:05] yes [09:07:58] catching up on the previous review and then I'll review that one [09:29:01] *** Quits: ziyeyang (ziyeyang@nat/intel/x-xhibzcztgxsdfezb) (Ping timeout: 240 seconds) [09:29:01] *** Quits: pniedzwx (pniedzwx@nat/intel/x-vabzjjgjtfqyrocx) (Ping timeout: 240 seconds) [09:30:42] *** Joins: ziyeyang (ziyeyang@nat/intel/x-uekidfkgtvvzfhuc) [09:31:39] *** Joins: pniedzwx (pniedzwx@nat/intel/x-aafxmmpyogpzvlnm) [09:50:20] jimharris: if I create iSCSI target by following commands [09:50:29] *** Quits: kjakimia (kjakimia@nat/intel/x-khgrgfnegiidcmed) (Ping timeout: 260 seconds) [09:50:30] ./rpc.py add_portal_group 1 127.0.0.1:3260 [09:50:33] ./rpc.py add_initiator_group 2 ANY 127.0.0.1/32 [09:50:36] ./rpc.py construct_target_node Target0 Target0_alias Nvme0n1:0 1:2 64 -d [09:50:39] *** Joins: kjakimia (kjakimia@nat/intel/x-avoqpwehgracxozi) [09:51:01] is the URL of "iscsi://127.0.0.1:3260/Target0/1" for that resource correct? [10:39:29] no - I think you need the fullname, including the node base [10:39:48] i.e. iqn.2016-06.io.spdk:Target0 [11:47:50] hmmm... ok, but in current code we never set the target [11:49:26] this is what I asked yesterday. The call to iscsi_set_targetname() is missing and was always getting "Async login fail" from iscsi [11:49:34] * from libiscsi [11:50:23] when I added this iscsi_set_targetname() login was succesfull. [11:50:44] So is the Target optional somehow in iSCSI? [12:48:57] *** Joins: travis-ci (~travis-ci@ec2-54-226-84-244.compute-1.amazonaws.com) [12:48:58] (spdk/master) vhost_nvme: add JSON config dump (Pawel Wodkowski) [12:48:58] Diff URL: https://github.com/spdk/spdk/compare/14cf1ad3ac9f...f23c48d59b39 [12:48:58] *** Parts: travis-ci (~travis-ci@ec2-54-226-84-244.compute-1.amazonaws.com) () [12:49:11] *** Joins: travis-ci (~travis-ci@ec2-54-221-82-230.compute-1.amazonaws.com) [12:49:11] (spdk/master) event/reactor: take into account ring metadata size in event mempools (Dariusz Stojaczyk) [12:49:12] Diff URL: https://github.com/spdk/spdk/compare/f23c48d59b39...90dfc392ccaf [12:49:12] *** Parts: travis-ci (~travis-ci@ec2-54-221-82-230.compute-1.amazonaws.com) () [12:51:22] *** Joins: travis-ci (~travis-ci@ec2-54-226-84-244.compute-1.amazonaws.com) [12:51:23] (spdk/master) vhost:Update the device config in vhost.conf.in (Liang Yan) [12:51:23] Diff URL: https://github.com/spdk/spdk/compare/de139e8c8bcc...cc87019ab65b [12:51:23] *** Parts: travis-ci (~travis-ci@ec2-54-226-84-244.compute-1.amazonaws.com) () [12:51:45] *** Joins: travis-ci (~travis-ci@ec2-54-226-84-244.compute-1.amazonaws.com) [12:51:46] (spdk/master) rpc: Add start_subsystems_init RPC to start subsystems when -w option is used (Shuhei Matsumoto) [12:51:46] Diff URL: https://github.com/spdk/spdk/compare/cc87019ab65b...28589dbbe864 [12:51:46] *** Parts: travis-ci (~travis-ci@ec2-54-226-84-244.compute-1.amazonaws.com) () [12:54:09] *** Joins: travis-ci (~travis-ci@ec2-54-226-84-244.compute-1.amazonaws.com) [12:54:10] (spdk/master) autobuild: On FreeBSD, install the contigmem driver (Seth Howell) [12:54:10] Diff URL: https://github.com/spdk/spdk/compare/28589dbbe864...86ee572b792b [12:54:10] *** Parts: travis-ci (~travis-ci@ec2-54-226-84-244.compute-1.amazonaws.com) () [13:07:11] in current code we never set the target but we expect the user to put the nodebase into the URL string [13:29:54] jimharris: but we parse this :) [13:32:39] never mind I will continue tommorow on this and send proper patches. [13:33:36] i guess i'm not understanding the issue - if we construct the session by individual parts, then we need to call iscsi_set_targetname() [13:34:16] but we should not need to call iscsi_set_targetname() if we are passing a full URL string and the nodebase is already in the string [13:34:32] at least that's how it's worked on the systems I've tested with so far [13:34:45] if you're seeing something different then let's fix it :) [14:36:17] *** Joins: travis-ci (~travis-ci@ec2-54-166-174-81.compute-1.amazonaws.com) [14:36:18] (spdk/master) nvmf: make each io qpair recycled by its own thread (Ziye Yang) [14:36:18] Diff URL: https://github.com/spdk/spdk/compare/86ee572b792b...cbbec6dd162d [14:36:18] *** Parts: travis-ci (~travis-ci@ec2-54-166-174-81.compute-1.amazonaws.com) () [15:57:35] *** Joins: jianC (~jianc@ip98-164-226-247.oc.oc.cox.net) [16:08:53] *** Joins: jianC_ (~jianc@wsip-184-189-201-114.oc.oc.cox.net) [16:11:59] *** Quits: jianC (~jianc@ip98-164-226-247.oc.oc.cox.net) (Ping timeout: 260 seconds) [16:19:35] *** Quits: jianC_ (~jianc@wsip-184-189-201-114.oc.oc.cox.net) (Ping timeout: 256 seconds) [16:19:40] *** Joins: jianC (~jianc@ip98-164-226-247.oc.oc.cox.net) [18:41:06] *** Joins: dlw1 (~Thunderbi@114.255.44.143) [18:41:10] *** Quits: dlw (~Thunderbi@114.255.44.143) (Read error: Connection reset by peer) [18:41:10] *** dlw1 is now known as dlw [18:42:11] *** Joins: dlw1 (~Thunderbi@114.255.44.143) [18:42:12] *** Quits: dlw (~Thunderbi@114.255.44.143) (Read error: Connection reset by peer) [18:42:12] *** dlw1 is now known as dlw [18:47:54] *** Joins: dlw1 (~Thunderbi@114.255.44.143) [18:47:55] *** Quits: dlw (~Thunderbi@114.255.44.143) (Read error: Connection reset by peer) [18:47:55] *** dlw1 is now known as dlw [19:29:41] *** Quits: jianC (~jianc@ip98-164-226-247.oc.oc.cox.net) () [23:59:03] *** Joins: dlw1 (~Thunderbi@114.255.44.143)