[01:05:19] *** Joins: tkulasek (~tkulasek@134.134.139.74) [06:38:10] *** Joins: mhae (0fd3c958@gateway/web/freenode/ip.15.211.201.88) [07:00:34] I'll write unit tests for operation split [07:56:15] thanks tkulasek [09:08:17] jimharris: ping on https://review.gerrithub.io/#/c/spdk/spdk/+/409251/ [09:41:35] *** Joins: travis-ci (~travis-ci@ec2-54-211-210-134.compute-1.amazonaws.com) [09:41:36] (spdk/master) Revert "nvmf: disconnect other connections if admin qpair disconnects." (Daniel Verkamp) [09:41:36] Diff URL: https://github.com/spdk/spdk/compare/145b2f7bd323...87ec451b070a [09:41:36] *** Parts: travis-ci (~travis-ci@ec2-54-211-210-134.compute-1.amazonaws.com) () [10:33:44] *** Quits: mhae (0fd3c958@gateway/web/freenode/ip.15.211.201.88) (Ping timeout: 260 seconds) [10:37:05] *** Quits: tkulasek (~tkulasek@134.134.139.74) (Ping timeout: 248 seconds) [14:22:41] jimharris: this should fix the Set Features AER errors for P4500: https://review.gerrithub.io/#/c/spdk/spdk/+/409352/ [14:23:09] missed that part of the spec the last N times I searched for it... [14:24:24] off by one error - you needed to look N+1 times :) [14:24:26] looks good to me [14:25:28] patch looks good - testing it on my system now [14:26:28] yep - works like a charm [14:28:46] how set are you on keeping the option to use a non-submodule libiscsi? [14:29:42] libiscsi directory structure just puts the include files in an "include" directory, but they get installed in an "iscsi" directory [14:29:52] so we cannot just #include "iscsi/iscsi.h" anymore [14:30:07] nor can we really #include "iscsi.h" [14:31:34] i could generate a tiny header file from the Makefile to enable using the correct include directory [14:32:32] or just ln -s include iscsi [14:42:14] can we 'make install' inside our own build dir or something? [14:42:24] or the symlink would be fine, probably [14:55:21] i'm going the symlink route [14:55:23] for now [16:14:35] *** Joins: travis-ci (~travis-ci@ec2-54-197-93-154.compute-1.amazonaws.com) [16:14:36] (spdk/master) SPDK 18.04 (Daniel Verkamp) [16:14:36] Diff URL: https://github.com/spdk/spdk/compare/87ec451b070a...9eb54cae6aca [16:14:36] *** Parts: travis-ci (~travis-ci@ec2-54-197-93-154.compute-1.amazonaws.com) () [16:21:59] *** Joins: travis-ci (~travis-ci@ec2-54-211-210-134.compute-1.amazonaws.com) [16:22:00] (spdk/v18.04.x) SPDK 18.04 (Daniel Verkamp) [16:22:00] Diff URL: https://github.com/spdk/spdk/compare/v18.04.x [16:22:00] *** Parts: travis-ci (~travis-ci@ec2-54-211-210-134.compute-1.amazonaws.com) () [18:06:03] Hi @drv, Can you review the following patch: https://review.gerrithub.io/#/c/spdk/spdk/+/409363. [22:14:37] *** Quits: gila (~gila@5ED4D9C8.cm-7-5d.dynamic.ziggo.nl) (Quit: Textual IRC Client: www.textualapp.com) [22:51:45] *** Joins: ming (18829d8b@gateway/web/freenode/ip.24.130.157.139) [22:52:13] "Virtio with 2MB hugepages: Enables SPDK Virtio to work with 2MB hugepages." [22:52:38] Could someone tell the git commit id for this feature? [23:15:20] *** Quits: ming (18829d8b@gateway/web/freenode/ip.24.130.157.139) (Quit: Page closed)