[00:03:15] *** Joins: danielwaddington (Daniel@nat/ibm/x-rvbvoofwvrjelnlu) [00:07:35] *** Quits: waddy (~Daniel@32.97.110.56) (Ping timeout: 276 seconds) [00:47:15] *** Quits: Param (~Param@106.51.65.217) (Quit: Param) [00:50:57] *** Joins: Param (~Param@106.51.65.217) [00:53:55] *** Quits: ziyeyang_ (~ziyeyang@192.55.54.39) (Quit: Leaving) [01:01:10] *** Joins: tomzawadzki (~tomzawadz@134.134.139.72) [01:01:41] *** Joins: tzawadzki (~tomzawadz@134.134.139.72) [01:01:41] *** Quits: tomzawadzki (~tomzawadz@134.134.139.72) (Remote host closed the connection) [01:09:35] *** Quits: tzawadzki (~tomzawadz@134.134.139.72) (Remote host closed the connection) [01:15:29] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Quit: Page closed) [01:17:19] jimharris: can we merge https://review.gerrithub.io/#/c/388615/ to resolve #215 on github? [01:17:22] *** Quits: baruch (~baruch@141.226.177.138) (Read error: Connection reset by peer) [02:00:36] Can somone look at https://review.gerrithub.io/#/c/386114/ and give -2 if the idea behind this patch is bad ? :) [02:22:32] *** Joins: baruch (~baruch@bzq-82-81-85-138.red.bezeqint.net) [06:21:32] *** Quits: Param (~Param@106.51.65.217) (Quit: Param) [06:26:16] *** Joins: Param (~Param@106.51.65.217) [06:38:08] *** Quits: baruch (~baruch@bzq-82-81-85-138.red.bezeqint.net) (Ping timeout: 248 seconds) [06:51:20] cs [06:51:42] oops - wrong window :) [07:09:20] *** Quits: Param (~Param@106.51.65.217) (Quit: Param) [08:10:02] *** Joins: Param (~Param@157.49.7.79) [08:16:49] *** Joins: lhodev (~Adium@inet-hqmc08-o.oracle.com) [08:16:57] *** Parts: lhodev (~Adium@inet-hqmc08-o.oracle.com) () [08:20:40] pausing the build pool for a second to swap fedora-05 to fedora26 [08:24:16] *** Joins: lhodev (~Adium@inet-hqmc03-o.oracle.com) [08:24:28] *** Parts: lhodev (~Adium@inet-hqmc03-o.oracle.com) () [08:33:27] pwodkowx - I think patch 388615 is generally ok - but i agree with your comments on the patch [08:36:24] on 386114 - I like this patch but will defer to drv since spdk_strerror_r was his idea :) [08:39:33] the only problem I see is that we've gotten rid of thread local variables everywhere in lib/util and this would add one back [08:41:34] clear [08:42:47] mszwed, looks like you're not the only one haha [08:53:17] darsto: can you rebase your virtio patch set? the next 5 patches all have multiple +2s we just need a rebase [08:53:36] k, on it [08:54:59] thanks [11:04:38] *** Joins: baruch (~baruch@141.226.177.138) [11:25:54] *** Joins: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) [11:26:08] *** Quits: lhodev (~Adium@66-90-218-190.dyn.grandenetworks.net) (Client Quit) [11:51:17] *** Quits: Param (~Param@157.49.7.79) (Quit: Param) [12:02:36] *** Joins: lhodev (~Adium@inet-hqmc03-o.oracle.com) [12:02:46] *** Parts: lhodev (~Adium@inet-hqmc03-o.oracle.com) () [12:31:11] *** Quits: danielwaddington (Daniel@nat/ibm/x-rvbvoofwvrjelnlu) (Read error: Connection reset by peer) [12:57:47] *** Joins: lhodev (~Adium@inet-hqmc03-o.oracle.com) [12:57:55] *** Parts: lhodev (~Adium@inet-hqmc03-o.oracle.com) () [13:16:50] jimharris: regarding https://review.gerrithub.io/#/c/388703/ - do we need to store the flags for a blob and persist them when we write out the metadata? [13:17:12] we do - that's coming in another patch [13:17:14] currently, nothing writes the flags descriptor, so I think if you read in a blob that has flags that we don't understand, we will drop them if the user calls sync [13:17:40] or we can hold off on this patch I can add them to this one [13:18:03] is that one of the patches you already have out for review? [13:18:09] no [13:18:41] I think we should probably get the full save/load functionality in the patch that bumps the version, at least [13:29:05] sure - will do [13:29:40] other than that, the patch looks good to me now [13:29:56] I was trying to think up a better name for "invalid_flags", since that sounds a little confusing, but I don't really have a better suggestion [13:30:03] maybe "required_flags", but that's not really clear either [15:46:08] *** Joins: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) [16:08:22] jimharris, darsto: one of the rte_virtio patches introduced a warning on Travis: https://travis-ci.org/spdk/spdk/builds/309219438 [16:08:25] fix is here: https://review.gerrithub.io/#/c/389648/ [16:08:56] (unless I'm missing some reason for the existence of the static global variable) [16:30:24] drv: I just pushed a new rev of the blob feature flag patch [16:30:43] https://review.gerrithub.io/#/c/388703/ [16:36:58] jimharris: look good, except there's some trailing whitespace in the unit test file [17:44:57] *** Joins: ziyeyang_ (~ziyeyang@134.134.139.75) [20:02:15] *** Joins: ziyeyang__ (~ziyeyang@192.55.54.42) [20:02:16] *** Quits: ziyeyang_ (~ziyeyang@134.134.139.75) (Remote host closed the connection) [20:17:06] *** Quits: ziyeyang__ (~ziyeyang@192.55.54.42) (Remote host closed the connection) [21:35:14] *** Joins: Param (~Param@106.51.65.217)