[00:16:40] That's OK. [00:16:59] Jim's idea if the reset fails, we should not do anything with the already submitted tasks. [00:17:08] tasks means the iSCSI tasks. [00:17:30] Normally, I agree with you. If reset succeeds, there will be no active tasks. [00:51:53] *** Quits: ziyeyang_ (~ziyeyang@134.134.139.83) (Quit: Leaving) [01:19:39] *** Quits: Shuhei (caf6fc61@gateway/web/freenode/ip.202.246.252.97) (Ping timeout: 260 seconds) [09:27:24] drv: https://review.gerrithub.io/#/c/387799/ [09:27:39] last patch in a set of 5 [09:28:22] jimharris: darsto_ has a -1 on that one [09:29:55] you're right - he posted that after my +2 and i hadn't refreshed my open page [09:29:58] i'll push the other 4 [09:32:16] so catch me up on the fio_plugin changes - is it passing now or do I still need to look at it? [09:32:38] it's still crashing [09:32:55] I've re-enabled the bdev/virtio changes on the test machine, so you can now test it just by pushing a review with the "false &&" removed from the script [09:33:39] ok cool - I'll dig into it as soon as I catch up on code reviews [14:27:34] jimharris: I pushed a cherry pick of the patch to disable fio testing on bdev/virtio for v17.10.x [14:27:37] https://review.gerrithub.io/#/c/388687/ [14:27:53] and then we can rebase Tomasz's two patches on that [14:28:25] done [16:06:38] bwalker: _spdk_blob_parse_page() has an assert on extent descriptors that length > 0 [16:07:06] is that right? I was thinking a zero-sized blob would have length = 0 [16:07:21] or do we just not write an extent descriptor if size is 0? [16:38:48] *** Joins: Shuhei (72b10586@gateway/web/freenode/ip.114.177.5.134) [16:39:00] *** Joins: ziyeyang_ (ziyeyang@nat/intel/x-zwmaetccxxuujmfy) [16:44:08] Making queue depth changeable by config file will be helpful for our purpose but should we wait for Gang's performance evaluation? [16:50:55] hi Shuhei - yes, I am ok with making it changeable, but would prefer to keep current default (64) [16:51:57] HI Jim, Thank you, I got it. [17:15:10] *** Quits: Shuhei (72b10586@gateway/web/freenode/ip.114.177.5.134) (Ping timeout: 260 seconds) [17:44:54] *** Quits: ziyeyang_ (ziyeyang@nat/intel/x-zwmaetccxxuujmfy) (Quit: Leaving) [18:39:08] *** Quits: tmonjalo (~quassel@184.203.134.77.rev.sfr.net) (Ping timeout: 255 seconds) [18:39:24] *** Joins: tmonjalo (~quassel@184.203.134.77.rev.sfr.net) [18:52:59] *** Joins: darsto__ (~dstojacx@89-68-135-211.dynamic.chello.pl) [18:55:57] *** Quits: darsto_ (~dstojacx@89-68-135-211.dynamic.chello.pl) (Ping timeout: 240 seconds) [19:57:18] *** Joins: ziyeyang_ (~ziyeyang@192.55.54.45)