[00:06:34] *** Quits: ziyeyang_ (~ziyeyang@192.55.54.40) (Remote host closed the connection) [00:07:24] *** Joins: ziyeyang_ (ziyeyang@nat/intel/x-opedppawbwsdqcck) [00:54:32] *** Joins: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) [00:59:30] *** Quits: ziyeyang_ (ziyeyang@nat/intel/x-opedppawbwsdqcck) (Ping timeout: 240 seconds) [01:02:07] *** Joins: ziyeyang_ (~ziyeyang@134.134.139.72) [01:04:44] *** Quits: ziyeyang_ (~ziyeyang@134.134.139.72) (Remote host closed the connection) [01:06:53] *** Joins: ziyeyang_ (~ziyeyang@134.134.139.72) [01:09:35] *** Joins: ziyeyang__ (~ziyeyang@134.134.139.72) [01:10:59] *** Quits: ziyeyang_ (~ziyeyang@134.134.139.72) (Remote host closed the connection) [01:13:05] *** Quits: ziyeyang__ (~ziyeyang@134.134.139.72) (Remote host closed the connection) [01:13:27] *** Joins: ziyeyang_ (~ziyeyang@192.55.54.40) [01:43:05] *** Joins: ziyeyang__ (ziyeyang@nat/intel/x-fkedhzljdizkknou) [01:43:05] *** Quits: ziyeyang_ (~ziyeyang@192.55.54.40) (Remote host closed the connection) [01:53:59] *** Quits: ziyeyang__ (ziyeyang@nat/intel/x-fkedhzljdizkknou) (Remote host closed the connection) [01:54:00] *** Joins: ziyeyang_ (~ziyeyang@134.134.139.72) [02:02:51] *** Quits: ziyeyang_ (~ziyeyang@134.134.139.72) (Remote host closed the connection) [05:18:50] *** Quits: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [07:32:50] *** Quits: tomzawadzki (~tzawadzk@192.55.54.36) (Ping timeout: 240 seconds) [08:19:39] *** Joins: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) [09:04:25] *** Quits: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [09:09:39] *** Joins: nKumar (uid239884@gateway/web/irccloud.com/x-gnqgtabzkftohgkk) [09:39:24] patch is mostly done for vhost - but I'm adding a unit test framework for the vhost lib so we can write some tests for the boundary checking, etc. [09:58:28] nice, sounds good [09:58:36] let me know when you have a patch ready for testing [10:22:55] *** Quits: sethhowe_ (~sethhowe@134.134.139.82) (Remote host closed the connection) [10:26:05] *** Joins: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) [10:27:30] *** Joins: sethhowe (~sethhowe@134.134.139.82) [10:33:58] *** Quits: sethhowe (~sethhowe@134.134.139.82) (Remote host closed the connection) [10:35:37] *** Joins: sethhowe (~sethhowe@192.55.54.42) [11:27:05] *** Quits: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [11:35:08] *** Joins: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) [11:52:01] *** Quits: gila (~gila@5ED4FE92.cm-7-5d.dynamic.ziggo.nl) (Quit: My Mac Pro has gone to sleep. ZZZzzz…) [12:01:49] hmmm - so this isn't really just as simple as splitting the iov [12:02:29] I *think* we need to recheck the gpa_to_vva at each 2MB boundary, just in case the iov spans two vhost memory regions [12:02:48] in practice this is probably never going to happen [12:04:16] actually the code change is pretty small - just needs more unit tests [13:02:23] jimharris: your vhost patches have check_format errors [13:02:47] yeah - I'm working on it [13:03:13] well I don't think the latest ones have check_format errors [13:03:17] i thought i'd fixed those [13:03:30] need to disable vhost_ut on freebsd [13:03:48] and getting an alignment issue with the vhost_ut after I add the iov tests [13:07:50] new revs pushed - you should be good to start testing, my last rev passed the vhost test machine [13:23:15] jimharris: at first glance, seems like it fixes the mkfs.ntfs issue [13:25:02] argh - i removed vhost_ut from the build but didn't condition its execution in unittest.sh [13:25:06] on freebsd [13:27:11] hmm, probably best to just say 'if [ -x test/unit/lib/vhost/whatever ]; then run ut...' rather than tying it to FreeBSD in unittest.sh [13:27:43] also, some of the compilers (e.g. wkb-fedora-03) are warning about a maybe-uninitialized variable [13:27:44] but then someone comes along and asks why we don't do that for all of the unittests [13:29:38] yeah, I guess I don't mind either way [13:29:49] probably best to say "if Linux" rather than "if not freebsd", though [15:28:34] peluse: I made some small mods to mock.h in this patch in case you want to review: https://review.gerrithub.io/#/c/371735/ [15:35:24] well, besides vhost we basically just compile against DPDK 17.08 [15:35:26] the release candidate [15:35:36] I had to add link to libnuma, but everything else just worked [17:26:09] *** Quits: nKumar (uid239884@gateway/web/irccloud.com/x-gnqgtabzkftohgkk) (Quit: Connection closed for inactivity)