[00:27:33] *** Joins: tomzawadzki (tzawadzk@nat/intel/x-bmkqisixbuuvkzdn) [00:54:57] *** Joins: pawelwod (86bfdc48@gateway/web/freenode/ip.134.191.220.72) [00:58:30] *** Joins: pwodkowx (pwodkowx@nat/intel/x-ptqsylxlcdghbjqm) [03:35:54] *** Quits: pawelwod (86bfdc48@gateway/web/freenode/ip.134.191.220.72) (Ping timeout: 260 seconds) [04:54:22] *** Parts: pwodkowx (pwodkowx@nat/intel/x-ptqsylxlcdghbjqm) ("Leaving") [04:54:47] *** Joins: pwodkowx (pwodkowx@nat/intel/x-ptqsylxlcdghbjqm) [04:55:07] *** Quits: pwodkowx (pwodkowx@nat/intel/x-ptqsylxlcdghbjqm) (Quit: Leaving) [05:11:19] *** Joins: johnmeneghini (~johnmeneg@pool-96-252-112-122.bstnma.fios.verizon.net) [05:11:20] *** Quits: johnmeneghini (~johnmeneg@pool-96-252-112-122.bstnma.fios.verizon.net) (Client Quit) [07:04:40] *** Joins: johnmeneghini (~johnmeneg@pool-96-252-112-122.bstnma.fios.verizon.net) [07:04:42] *** Quits: johnmeneghini (~johnmeneg@pool-96-252-112-122.bstnma.fios.verizon.net) (Client Quit) [07:05:00] *** Joins: johnmeneghini (~johnmeneg@pool-96-252-112-122.bstnma.fios.verizon.net) [08:32:15] *** Quits: tomzawadzki (tzawadzk@nat/intel/x-bmkqisixbuuvkzdn) (Ping timeout: 258 seconds) [10:37:40] peluse: do you have a demo of how you're going to use these mock functions from https://review.gerrithub.io/#/c/363441/ ? [13:53:15] drv, In the next patch I will show how they're used. I can paste some into a gist if you want to see. My plan was to do just that small patch next and then after that tie the --wrap with the current use of stubs & globals in one mock library [13:53:39] ok, just wanted to see where we should end up with the variables that control the stubs [13:53:40] and then follow that with a bunch of patches that sue them and beef up coverage on nvme.c [13:53:43] whether they should be static or not [13:53:54] not I think [13:53:57] so having at least one user would be a good start [13:54:12] in the same patch? [13:54:18] nah, a separate one is fine [13:54:23] just as long as we can see how it will be used [13:54:34] so I can tell bwalker he's wrong ;) [13:54:39] sounds good, that was the preference on the previous set. first patch, setup the frameowrk, subsequent patches use it [13:54:56] I'm going to make up a new keyword static-as-needed [14:58:43] bwalker, please take a look at the readme changes if you get a chance, I'm out starting tomorrow morn through end of week. [14:59:05] drv, yeah, yanked the static back out for now on the mock stuff, will submit the first use of it next week when I get back [14:59:12] ok, cool [15:28:05] test failure looks like seg fault or some shit like that on unrelated patch (readme). Does this happen a lot or am I just really unlucky lately? :) [15:35:29] er, well, the wrap patch not the readme. https://ci.spdk.io/builds/review/83d9fb90f023065ebb2479ad5833ca6943c04e25.1496786432 [15:49:54] just unlucky [15:50:41] we have some intermittent test failures going on right now [15:57:47] OK, do we have a list of them anywhere, issues on github or something? [16:06:59] not right now - it would be good to track them somewhere, though [16:07:09] the one that you hit is an intermittent SPDK nvme fio_plugin crash [16:53:13] drv, yeah maybe just a github issue starting with CI_TEST: or something simple like that [16:53:28] unless you knocking them out as you hit them of course :) [16:53:45] well, that is the goal, but we have not been making very good progress on that front... [16:54:05] when I get back I have 2 systems here with real HW and I plan to try and get a real test pool going here also so... [16:55:45] sounds good [16:56:00] the real problem is that some of these are hard to reproduce and therefore hard to debug (the fio_plugin one is pretty rare) [16:56:26] well I have bad luck on my side then! ;) [18:49:20] *** Joins: ystu (dbe493a1@gateway/web/freenode/ip.219.228.147.161) [18:50:54] *** Quits: ystu (dbe493a1@gateway/web/freenode/ip.219.228.147.161) (Client Quit) [22:19:50] *** Joins: tsuyoshi (b42b2067@gateway/web/freenode/ip.180.43.32.103)